openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
57 stars 134 forks source link

infra: Fix subscription of SRIOV for Hypershift CI #1963

Closed sshnaidm closed 1 month ago

sshnaidm commented 1 month ago

/cherry-pick 4.16

openshift-cherrypick-robot commented 1 month ago

@sshnaidm: once the present PR merges, I will cherry-pick it on top of 4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1963#issuecomment-2213966533): >/cherry-pick 4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
SchSeba commented 1 month ago

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, sshnaidm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/OWNERS)~~ [SchSeba] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 month ago

@sshnaidm: cannot checkout 4.16: error checking out "4.16": exit status 1 error: pathspec '4.16' did not match any file(s) known to git

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1963#issuecomment-2213966533): >/cherry-pick 4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sshnaidm commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@sshnaidm: new pull request created: #1964

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1963#issuecomment-2214347363): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.