search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
57 stars 134 forks source link

OCPBUGS-36774: [release-4.15] Update ptpconfig to configure NAV-TIMELS to be periodically sent via the UBX-CFG-MSG message #1966

Closed aneeshkp closed 2 weeks ago

aneeshkp commented 1 month ago

This is cherry pick cherry-pick of

  1. https://github.com/openshift-kni/cnf-features-deploy/pull/1929
  2. https://github.com/openshift-kni/cnf-features-deploy/pull/1943

This commit enables NAV-TIMELS indications on WPC T-GM configurations. This is required to enable automatic leap seconds file update. The phc2sys options are also changed to obtain the leap seconds from phc instead of passing them as the command line argument

aneeshkp commented 1 month ago

/jira cherry-pick OCPBUGS-35759

openshift-ci-robot commented 1 month ago

@aneeshkp: Jira Issue OCPBUGS-35759 has been cloned as Jira Issue OCPBUGS-36774. Will retitle bug to link to clone. /retitle OCPBUGS-36774: [release-4.15] Update ptpconfig to configure NAV-TIMELS to be periodically sent via the UBX-CFG-MSG message

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1966#issuecomment-2218460404): >/jira cherry-pick OCPBUGS-35759 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-36774, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1966): >This is cherry pick cherry-pick of >1. https://github.com/openshift-kni/cnf-features-deploy/pull/1929 >2. https://github.com/openshift-kni/cnf-features-deploy/pull/1943 > >This commit enables NAV-TIMELS indications on WPC T-GM >configurations. This is required to enable automatic >leap seconds file update. >The phc2sys options are also changed to obtain the leap >seconds from phc instead of passing them as the command >line argument Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 1 month ago

/approve /lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, nishant-parekh, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/release-4.14/ztp/OWNERS)~~ [nishant-parekh,vitus133] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aneeshkp commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-36774, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1966#issuecomment-2223106225): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 1 month ago

/jir refresh

aneeshkp commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-36774, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1966#issuecomment-2223251652): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 3 weeks ago

/re-title OCPBUGS-36774: [release-4.14] Update ptpconfig to configure NAV-TIMELS to be periodically sent via the UBX-CFG-MSG message #1966

vitus133 commented 2 weeks ago

/close

covered by #2002

openshift-ci[bot] commented 2 weeks ago

@vitus133: Closed this PR.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1966#issuecomment-2293379396): >/close > >covered by #2002 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 weeks ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-36774. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1966): >This is cherry pick cherry-pick of >1. https://github.com/openshift-kni/cnf-features-deploy/pull/1929 >2. https://github.com/openshift-kni/cnf-features-deploy/pull/1943 > >This commit enables NAV-TIMELS indications on WPC T-GM >configurations. This is required to enable automatic >leap seconds file update. >The phc2sys options are also changed to obtain the leap >seconds from phc instead of passing them as the command >line argument Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.