search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
57 stars 134 forks source link

OCPBUGS-37044: revert phc2sys leap option to fixed -37 seconds #1968

Open vitus133 opened 1 month ago

vitus133 commented 1 month ago

This commit reverts phc2sys automatic leap second selection back to the fixed -37 seconds. The change provides a workaround to the issue exibited by the linuxptp 3.1.1, where phc2sys configured with the automatic leap second handling (-w option) works incorrectly, and so the node system time is off by the leap second amount (37 seconds).

/cc @aneeshkp @jzding @josephdrichard @nishant-parekh

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/release-4.15/ztp/OWNERS)~~ [vitus133] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@vitus133: This pull request references Jira Issue OCPBUGS-37044, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1968): >This commit reverts phc2sys automatic leap second selection back to the fixed -37 seconds. The change provides a workaround to the issue exibited by the linuxptp 3.1.1, where phc2sys configured with the automatic leap second handling (-w option) works incorrectly, and so the node system time is off by the leap second amount (37 seconds). > >/cc @aneeshkp @jzding @josephdrichard @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@vitus133: This pull request references Jira Issue OCPBUGS-37044, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1968#issuecomment-2228271806): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@vitus133: This pull request references Jira Issue OCPBUGS-37044, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37043](https://issues.redhat.com//browse/OCPBUGS-37043) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-37043](https://issues.redhat.com//browse/OCPBUGS-37043) targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @gsr-shanks

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1968#issuecomment-2228273705): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fcnf-features-deploy). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 1 month ago

/hold

aneeshkp commented 1 month ago

/hold