search

openshift-kni / cnf-features-deploy

Kustomize configs for installing CNF features and e2e functional tests for verifying feature deployment/integration
Apache License 2.0
57 stars 134 forks source link

ztp: Extend IPsec optional feature to support SNO+1 and MNO #1972

Closed sabinaaledort closed 1 month ago

sabinaaledort commented 1 month ago

Configure IPsec encryption for external traffic on SNO, SNO+1 and MNO.

sabinaaledort commented 1 month ago

/cc @yuvalk @lack

bradyallenjohnson commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@bradyallenjohnson: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift-kni/cnf-features-deploy/pull/1972#issuecomment-2236670419): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
browsell commented 1 month ago

/hold

browsell commented 1 month ago

/unhold

yuvalk commented 1 month ago

/lgtm fine by me, @lack you have the final word, please approve if you think this is good enough

lack commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, sabinaaledort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ztp/OWNERS](https://github.com/openshift-kni/cnf-features-deploy/blob/master/ztp/OWNERS)~~ [lack] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment