openshift-kni / debug-tools

debug and troubleshooting tools to check CNF workload configuration - unsupported
Apache License 2.0
0 stars 10 forks source link

irq: don't force to report on stdout #38

Closed ffromani closed 2 years ago

ffromani commented 2 years ago

Abstract the destination where the irqs.Reporter does its reporting, to improve the testability and the reusability of the package.

Use this code in the irqwatch command, instead of having its own private reporter code.

Signed-off-by: Francesco Romani fromani@redhat.com

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/debug-tools/blob/main/OWNERS)~~ [fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 2 years ago

@marioferh

ffromani commented 2 years ago

/retest

ffromani commented 2 years ago

merged in #40