search

openshift-kni / debug-tools

debug and troubleshooting tools to check CNF workload configuration - unsupported
Apache License 2.0
0 stars 10 forks source link

podres: does not omit NUMA nodes with id 0 under the topology info #43

Closed cynepco3hahue closed 2 years ago

cynepco3hahue commented 2 years ago

proto3 generates the topology info with the int value instead of pointer and it creates a problem during the json marshal, because it omits field via default values.

Signed-off-by: Artyom Lukianov alukiano@redhat.com

cynepco3hahue commented 2 years ago

Tested locally

{"name":"busybox-1","namespace":"default","containers":[{"name":"busybox-2","cpu_ids":[2],"memory":[{"memory_type":"memory","size":67108864,"topology":{"nodes":[{"ID":0}]}}]}]}

see {"nodes":[{"ID":0}]}}]}]}

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cynepco3hahue, fromanirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/debug-tools/blob/main/OWNERS)~~ [cynepco3hahue,fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment