openshift-kni / debug-tools

debug and troubleshooting tools to check CNF workload configuration - unsupported
Apache License 2.0
0 stars 10 forks source link

ethtool: add replacement for ethtool -k and -l #54

Closed ffromani closed 2 years ago

ffromani commented 2 years ago

Add commands to act as simple replacement for ethtool -l and ethtool -k.

even though very recent linux kernel implemented a new and more capable netlink interface to query the ethernet properties, we intentionally consume a ioctl-based package because:

  1. ioctl capabilities are fine for our use case (we don't need more modern and powerful features enabled by netlink just yet)
  2. we maximize the backward compatibility
  3. netlink-based packages are less mature
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/debug-tools/blob/main/OWNERS)~~ [fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 2 years ago

also, e2e tests are missing (and not really sure how to add them yet)

ffromani commented 2 years ago

also, e2e tests are missing (and not really sure how to add them yet)

e2e tests, at least a basic version of them, added

yanirq commented 2 years ago

/lgtm