search

openshift-kni / debug-tools

debug and troubleshooting tools to check CNF workload configuration - unsupported
Apache License 2.0
0 stars 10 forks source link

podinfo: Solve error in podinfo template #69

Closed jlojosnegros closed 2 years ago

jlojosnegros commented 2 years ago

When some pod has "requests" but not "limits" a comma appears before the "resource" label making the json wrong formatted.

pod-info command info: #64

ffromani commented 2 years ago

/lgtm /approve unit test coverage would be nice (can be done in a followup PR)

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, jlojosnegros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/debug-tools/blob/main/OWNERS)~~ [fromanirh,jlojosnegros] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jlojosnegros commented 2 years ago

/cherry-pick release-4.10

As #64 has been only cherry-picked to 4.10 this change need to be also cherry-picked to the same release.

openshift-cherrypick-robot commented 2 years ago

@jlojosnegros: new pull request created: #70

In response to [this](https://github.com/openshift-kni/debug-tools/pull/69#issuecomment-1232597433): >/cherry-pick release-4.10 > >As #64 has been only cherry-picked to 4.10 this change need to be also cherry-picked to the same release. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.