Building on ideas from #270 after talking with @kononovn
Instead of copying the entire client.Settings struct, only keep around the kubernetes.Interface that you use during some of these Node operations. This could also apply to all of the other k8s-related object funcs/pkgs.
This will help ease-of-use when writing unit tests that target this code as well because you don't have to worry about the other clients, just the kubernetes.Fake clientset.
achuzhoy
commented
4 months ago
Building on ideas from #270 after talking with @kononovn
Instead of copying the entire
client.Settingsstruct, only keep around thekubernetes.Interfacethat you use during some of theseNodeoperations. This could also apply to all of the other k8s-related object funcs/pkgs.This will help ease-of-use when writing unit tests that target this code as well because you don't have to worry about the other clients, just the
kubernetes.Fakeclientset.Does not break any public functionality.