search

openshift-kni / eco-goinfra

Apache License 2.0
6 stars 32 forks source link

Add ManagedCluster to olm package #340

Closed ddmitrie closed 1 month ago

trewest commented 2 months ago

@ddmitrie currently you are using the runtime client to work with these resources but ocm provides a clientset that you can utilize - https://github.com/open-cluster-management-io/api/tree/main/client/cluster/clientset/versioned/typed/cluster/v1. Please add this to our clients.Settings struct and utilize it in this pkg. Please reference the updates done to the clients pkg in this PR - https://github.com/openshift-kni/eco-goinfra/pull/291

klaskosk commented 2 months ago

@ddmitrie Hello! Thanks for adding this CR, it's going to be useful for a test I'm migrating. Is there anything I can do to help with moving along the PR?

kononovn commented 1 month ago

@ddmitrie Please re-base on top of latest main.

trewest commented 1 month ago

Closing since https://github.com/openshift-kni/eco-goinfra/pull/416 is already merged