openshift-kni / eco-goinfra

Apache License 2.0
7 stars 33 forks source link

Add ingress controller unit tests #366

Closed sebrandon1 closed 5 months ago

sebrandon1 commented 5 months ago

Note: It looks like the Update() is fundamentally broken because it does not appear you can modify IngressController objects once they are created. I tried various things to try and get it to work.

I left my test in there but commented out until we decide what to do with the Update() function itself.

Other changes:

Resolves: https://github.com/openshift-kni/eco-goinfra/issues/361

sebrandon1 commented 5 months ago

Updated for the comments left.

I removed my commented out test for Update() but I'm pretty sure that function doesn't work still. Do we want to maybe address that in another PR?