search

openshift-kni / eco-goinfra

Apache License 2.0
6 stars 32 forks source link

Add MultiClusterEngine to OCM package #427

Open ddmitrie opened 1 month ago

achuzhoy commented 1 month ago

is OCM the right place? cc @trewest @vkolodny

trewest commented 1 month ago

@ddmitrie All new public functions/methods require unit tests. Can you add unit tests following these guidelines? https://github.com/openshift-kni/eco-goinfra?tab=readme-ov-file#note-every-new-package-requires-a-coverage-of-all-its-public-functions-with-unit-tests-unit-tests-are-located-in-the-same-package-as-the-resource-in-a-file-with-the-name-resource_testgo-examples-can-be-found-in-configmap_testgo-and-metallb_testgo

trewest commented 2 weeks ago

Converted to Draft. Seems like there are some conflicts between this pkg and the assisted pkg. We need to implement these APIs ourselves to address them.