search

openshift-kni / eco-goinfra

Apache License 2.0
7 stars 33 forks source link

secret: added package unit tests #440

Closed eldar101 closed 2 months ago

eldar101 commented 4 months ago

Unittests for the secret package.

eldar101 commented 3 months ago

@ElaiShalevRH Please review and ping me.

kononovn commented 3 months ago

@eldar101 Please re-base. There is new function in secret package

kononovn commented 3 months ago

@eldar101 Please change commit message and PR headline to:

secret: added package unit tests

kononovn commented 3 months ago

@eldar101 Please fix linter issues. Please run > make lint in order to make sure that basic check pass

eldar101 commented 3 months ago

Fixing failures from the "checks" tab

kononovn commented 3 months ago

@eldar101 Check still failed. Please fix.

eldar101 commented 3 months ago

Fixed all lint issues locally. lint didn't work locally for me until I fixed path with: echo 'export PATH=$PATH:$(go env GOPATH)/bin' >> ~/.profile