search

openshift-kni / eco-goinfra

Apache License 2.0
6 stars 32 forks source link

keda pkg: kedaController object handler added #448

Closed elenagerman closed 3 weeks ago

elenagerman commented 1 month ago

Please use another version of operator

@kononovn there is no v2.12.0 for the ""github.com/kedacore/keda-olm-operator/apis/keda/v1alpha1""

you are talking about different repo "github.com/kedacore/keda/v2/apis/keda/v1alpha1". This second one is using a correct version,but it's another MR: https://github.com/openshift-kni/eco-goinfra/pull/449

elenagerman commented 3 weeks ago

@kononovn now it start to fail on the integration stage, I have no idea what is a reason

elenagerman commented 3 weeks ago

@kononovn I don't understand what is standing behind an idea to add integration with eco-gotest to the MR check. Now we'll need to open two MRs? Anyway I do not understand how it should work? Code that was not merged yet in eco-goinfra need to be synced with eco-gotests?

kononovn commented 3 weeks ago

@kononovn I don't understand what is standing behind an idea to add integration with eco-gotest to the MR check. Now we'll need to open two MRs? Anyway I do not understand how it should work? Code that was not merged yet in eco-goinfra need to be synced with eco-gotests?

No we just test that both projects are comparable and there is no dependency conflicts between libs