search

openshift-kni / eco-goinfra

Apache License 2.0
6 stars 32 forks source link

multiclusterhub pkg: added package and unit tests #451

Open ElaiShalevRH opened 4 weeks ago

ElaiShalevRH commented 4 weeks ago

Created multiclusterhub.go and multiclusterhub_test.go. Made changes to the clients.go to accept the new import. The rest of the the changes were induced by running go mod / vendor as advised.

ElaiShalevRH commented 4 weeks ago

@achuzhoy @trewest

trewest commented 4 weeks ago

@ElaiShalevRH This PR is bumping the k8s modules to v29 and we are not ready to make this move yet. I would recommend seeing if there is an older commit that you can pull from mch operator until we do the bump in our project. Try the release-2.10 branch

ElaiShalevRH commented 3 weeks ago

Hey @trewest, changed operator to an older version, changes now seem minimal. Also I've addressed the comments.

trewest commented 3 weeks ago

@ElaiShalevRH Added a few comments. Also, please add a Create method

trewest commented 2 weeks ago

Spoke to Elai, will most likely need to implement this ourselves as the hive version conflict with other modules in the project

trewest commented 1 week ago

Converted to Draft. Seems like there are some conflicts between this pkg and the assisted pkg. We need to implement these APIs ourselves to address them.