openshift-kni / eco-goinfra

Apache License 2.0
6 stars 32 forks source link

Add eco-gotests 'make vet' to PR checks #455

Closed sebrandon1 closed 3 weeks ago

sebrandon1 commented 3 weeks ago

Upon new PRs, clone both repos down (eco-gotests and eco-goinfra) and then replace the eco-goinfra with the local copy in the eco-gotests go.mod. Once the replacement is done, run the make vet path in the eco-gotests folder to see if everything compiles correctly.

This was previously not possible to test because eco-gotests was private.

image

achuzhoy commented 3 weeks ago

/lgtm

sebrandon1 commented 3 weeks ago

If the ignore-dep-check label is set, the whole action is skipped.

image

This will be useful when incompatibilies are not avoidable.