search

openshift-kni / eco-goinfra

Apache License 2.0
6 stars 32 forks source link

storage: add pull and deletes plus tests to storageclass #466

Closed klaskosk closed 2 weeks ago

klaskosk commented 3 weeks ago

Added a PullClass function to the storage package; added Delete, DeleteAndWait, and WaitUntilDeleted methods to ClassBuilder; and added unit tests for all of the functions in storageclass.go.

klaskosk commented 3 weeks ago

@kononovn Updated the test, although there's no check for a nil client in NewClassBuilder since the apiClient field hasn't been narrowed so it would be redundant with validate

kononovn commented 2 weeks ago

@kononovn Updated the test, although there's no check for a nil client in NewClassBuilder since the apiClient field hasn't been narrowed so it would be redundant with validate

I know just to make it more consistent can you add to NewBuilder following condition? https://github.com/openshift-kni/eco-goinfra/blob/30c5d20d5b39439e9d23a9740f2b5f6eef4ac9ab/pkg/assisted/agentclusterinstall.go#L51