search

openshift-kni / eco-goinfra

Apache License 2.0
6 stars 32 forks source link

ocm: add klusterlet addon config and unit tests #478

Closed klaskosk closed 1 week ago

klaskosk commented 2 weeks ago

Adds the KlusterletAddonConfig to the existing ocm package along with unit tests for the new resource.

klaskosk commented 1 week ago

@kononovn Thanks for your review, I've updated the PR accordingly

trewest commented 1 week ago

@klaskosk Shouldn't this be in the ocm pkg?

klaskosk commented 1 week ago

@trewest I'm not too familiar with what counts as OCM or not, but if you think it would be better as part of OCM I can move it

trewest commented 1 week ago

@trewest I'm not too familiar with what counts as OCM or not, but if you think it would be better as part of OCM I can move it

@klaskosk yeah I typically try to group resources by group as much as I can

$ oc explain klusterletaddonconfigs.agent.open-cluster-management.io | head -n 3
GROUP:      agent.open-cluster-management.io
KIND:       KlusterletAddonConfig
VERSION:    v1
$ oc explain managedcluster | head -n 3
GROUP:      cluster.open-cluster-management.io
KIND:       ManagedCluster
VERSION:    v1

If it isn't too much trouble, let's move it into the ocm pkg

klaskosk commented 1 week ago

@trewest Ah, thanks for the explanation. I've updated the PR to move it to the ocm package