openshift-kni / install-scripts

Installation scripts for OpenShift KNI clusters
14 stars 20 forks source link

[CNV] need procedure to test 2.1.X upgrades #143

Closed karmab closed 5 years ago

karmab commented 5 years ago

there is no procedure on how to pass from one cnv2.1.X version to 2.1.Y so this can't be tested

karmab commented 5 years ago

@rthallisey ^

rthallisey commented 5 years ago
export OLD_TAG=v2.1.0-43
export NEW_TAG=v2.1.0-47
curl -k https://pkgs.devel.redhat.com/cgit/containers/hco-bundle-registry/plain/qe-testing.sh?h=cnv-2.1-rhel-8 | HCO_BUNDLE_REGISTRY_TAG=$OLD_TAG bash -x

# Test v2.1.0-43 works, then upgrade to v2.1.0-47
oc get catalogsource -n openshift-marketplace hco-catalogsource -o yaml | sed 's/hco-bundle-registry:v.*$/hco-bundle-registry:$NEW_TAG/' | oc apply -n openshift-marketplace -f -

There may be one may step here where have to approve the upgrade.

rthallisey commented 5 years ago

cc @lveyde

simon3z commented 5 years ago

@rthallisey have you tested the procedure?

rthallisey commented 5 years ago

this may not work because it's the same CSV version. @lveyde any ideas?

fabiand commented 5 years ago

Please also note that the snippet above has a typo which renders it useless. (OLD_TAG is not recognized)

karmab commented 5 years ago

tested the procedure (without the typos) and while the catalogsource got updated, nothing more is happening

had a look at the installplan in openshift-cnv namespace and it contains the following

spec:
  approval: Manual
  approved: true
  clusterServiceVersionNames:
  - kubevirt-hyperconverged-operator.v2.1.0
rthallisey commented 5 years ago

We're working on having a temporary CSV to work around the testing. I'm starting a mail thread explaining it.

fabiand commented 5 years ago

@rthallisey could you explain briefly why the snippet does not work? Because it sounds like you know the problem and are working on the solution :)

rthallisey commented 5 years ago

This doesn't work because it's the same CSV. OLM sees kubevirt-hyperconverged-operator.v2.1.0 and it sees kubevirt-hyperconverged-operator.v2.1.0 from the new image and does nothing. The trigger is a new CSV. I explained the solution in more detail on the ml.