openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 28 forks source link

MGMT-17305: Wipe installation disk on IBI #493

Closed tsorya closed 4 months ago

tsorya commented 4 months ago

MGMT-17305: Wipe installation disk on IBI

  1. Adding installation disk cleanup feature
  2. In order to make it work as full flow in ibipreparation moved bash commands to it
  3. Adding skip cleanup option
openshift-ci-robot commented 4 months ago

@tsorya: This pull request references MGMT-17305 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/493): >[MGMT-17305](https://issues.redhat.com//browse/MGMT-17305): Wipe installation disk on IBI >1. Adding installation disk cleanup feature >2. In order to make it work as full flow in ibipreparation moved bash commands to it >3. Adding skip cleanup option Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 months ago

@tsorya: This pull request references MGMT-17305 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/493): >[MGMT-17305](https://issues.redhat.com//browse/MGMT-17305): Wipe installation disk on IBI >1. Adding installation disk cleanup feature >2. In order to make it work as full flow in ibipreparation moved bash commands to it >3. Adding skip cleanup option Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@tsorya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibu-e2e-flow 0f93bc20b96025fb17944eb7900245fbb3bb8d6f link false /test ibu-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tsorya commented 4 months ago

/retest