search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

CNF-12605: move precache workload cli into lca-cli #494

Closed pixelsoccupied closed 1 month ago

pixelsoccupied commented 1 month ago

A simple move from ./main to ./lca-cli to build precache in one shot

/cc @donpenney @rauhersu @jc-rh

openshift-ci-robot commented 1 month ago

@pixelsoccupied: This pull request references CNF-12605 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/494): >A simple move from ./main to ./lca-cli to build precache in one shot > >/cc @donpenney @rauhersu @jc-rh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pixelsoccupied commented 1 month ago

/hold need to coordinate with midstream!

donpenney commented 1 month ago

/lgtm

rauhersu commented 1 month ago

Midstream changes underway, I will get back as soon as they are merged.

rauhersu commented 1 month ago

please, go ahead. Midstream changes already merged.

pixelsoccupied commented 1 month ago

/unhold

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment