search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

CNF-12652: bundle: Update csv annotations in LCA bundle #496

Closed leo8a closed 1 month ago

leo8a commented 1 month ago

Sets proxy-aware and fips-compliant annotations to true in the LCA bundle, this will notify users installing LCA from the official catalogs about these operator's capabilities.

image

/cc @rauhersu @omertuc @jc-rh

omertuc commented 1 month ago

/lgtm

jc-rh commented 1 month ago

should disconnected be true too?

rauhersu commented 1 month ago

/hold

We will need extra midstream changes to claim 'fips compliant'. I will let you know when ready. Additionally, I believe we should mimic those changes as part of the upstream build, to keep them both as symmetrical as we can.

leo8a commented 1 month ago

should disconnected be true too?

yes, we do support LCA deployments in disconnected envs (also tested by QE)

rauhersu commented 1 month ago

/lgtm /unhold

donpenney commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@leo8a: This pull request references CNF-12652 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/496): >Sets `proxy-aware` and `fips-compliant` annotations to true in the LCA bundle, this will notify users installing LCA from the official catalogs about these operator's capabilities. > >![image](https://github.com/openshift-kni/lifecycle-agent/assets/13664224/cdbcbee8-57cf-499b-b151-4a36faeec8b8) > >/cc @rauhersu @omertuc @jc-rh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.