search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 28 forks source link

OCPBUGS-33535: export associated storage classes when exporting localvolumes #501

Closed Missxiaoguo closed 4 months ago

Missxiaoguo commented 4 months ago

The storage classes that are being used in the localvolumes should be exported and restored along with localvolumes during post-pivot as well.

openshift-ci-robot commented 4 months ago

@Missxiaoguo: This pull request references Jira Issue OCPBUGS-33535, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/501): >The storage classes that are being used in the localvolumes should be exported and restored along with localvolumes during post-pivot as well. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Missxiaoguo commented 4 months ago

/uncc @oourfali /cc @donpenney @leo8a

donpenney commented 4 months ago

/lgtm

jc-rh commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [jc-rh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
donpenney commented 4 months ago

/override ci/prow/integration ci/prow/ci-index

openshift-ci[bot] commented 4 months ago

@donpenney: Overrode contexts on behalf of donpenney: ci/prow/ci-index, ci/prow/integration

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/501#issuecomment-2108511571): >/override ci/prow/integration ci/prow/ci-index Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 months ago

@Missxiaoguo: Jira Issue OCPBUGS-33535: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33535 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/501): >The storage classes that are being used in the localvolumes should be exported and restored along with localvolumes during post-pivot as well. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.