openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

CNF-12712: Add badges and code-coverage targets #514

Closed leo8a closed 1 month ago

leo8a commented 1 month ago

This PR proposes the following:

/cc @donpenney

donpenney commented 1 month ago

/cc @jc-rh

donpenney commented 1 month ago

/lgtm

donpenney commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@leo8a: This pull request references CNF-12712 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/514): >This PR proposes the following: > >- Updates README.md with some badges. >- Fixes some misspell, ineffassign and gofmt recommendations provided by the goreportcard. >- Adds code-coverage target to Makefile and a config file, these could be used (e.g., in the ci-job or in local by devs) at any moment. > >/cc @donpenney Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.