search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

MGMT-17828: LCA should allow reconfiguration if hostname wasn't provided #518

Closed tsorya closed 1 month ago

tsorya commented 1 month ago
  1. We should block localhost as hostname
  2. In case hostname was not provided as part of seed reconfiguration we should use current node hostname
  3. Hostname should be set with hostnamectl command rather than with /etc/hostname file in order to be changed immediately
openshift-ci-robot commented 1 month ago

@tsorya: This pull request references MGMT-17828 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/518): >1. We should block localhost as hostname >2. In case hostname was not provided as part of seed reconfiguration we should use current node hostname >3. Hostname should be set with hostnamectl command rather than with /etc/hostname file in order to be changed immediately > > > ># Background / Context > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@tsorya: This pull request references MGMT-17828 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/518): >1. We should block localhost as hostname >2. In case hostname was not provided as part of seed reconfiguration we should use current node hostname >3. Hostname should be set with hostnamectl command rather than with /etc/hostname file in order to be changed immediately > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
donpenney commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment