openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade

Apache License 2.0

6 stars 26 forks source link

OCPBUGS-33786 - Fix SELinux issues in IBI when running outside of a container #519

Closed javipolo closed 1 month ago

javipolo commented 1 month ago

Background / Context

https://github.com/openshift-kni/lifecycle-agent/commit/e20c260d00eb2c9b03a6b174151615b884c5c85f broke the ability to set unexisting selinux contexts to files introduced by https://github.com/openshift-kni/lifecycle-agent/commit/f26ae70d96640cf7b974b5d5ad23ee2db967d228

Solution / Feature Overview

Just change the script to install_exec_t context before running it

/cc @tsorya /cc @donpenney

tsorya commented 1 month ago

Lets have jira please

javipolo commented 1 month ago

Lets have jira please

ACK

Jira ticket created and commit & PR updated to reflect the ticket

tsorya commented 1 month ago

I hope we will find better way in future /lgtm

donpenney commented 1 month ago

/lgtm

javipolo commented 1 month ago

/hold

javipolo commented 1 month ago

Drastically changed the solution to a super simpler one! :)

/unhold

donpenney commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment