openshift-ci-robot
commented
4 months ago @donpenney: This pull request references CNF-12403 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/520):
># Background / Context
>
>LCA runs system health checks during SeedGen and IBU to ensure that the cluster is healthy and stable before proceeding.
>
># Issue / Requirement / Reason for change
>
>An unhealthy subscription means there may not be a corresponding CSV. The existing health checks validate the CSV status, but if the CSV doesn't exist, that health check passes. As a result, the user may generate a seed image, for example, without realizing that the desired operators have not actually been installed.
>
># Solution / Feature Overview
>
>Introducing a Subscription health check gives added protection by ensuring all subscriptions are in a healthy state.
>
># Implementation Details
>
>This update adds a Subscription check to the set of system health checks, along with optionality for this specific check. The Subscription check ensures that each subscription CR has no conditions set to true, which indicates the subscription is healthy.
>
>This check is skipped in the postpivot Upgrade stage handler, as it is expected that the catalog sources will not have been updated at this point, and each subscription would therefore be reported as unhealthy.
>
>One implication of the Subscription health check is that there are no updates pending, meaning that the corresponding operators are running the latest available version, depending on the subscription configuration. In order to allow the user to proceed on a cluster without completing such updates, should they so desire, LCA will look for an annotation to determine whether to disable or skip this specific health check. This annotation can be added to either the IBU or Seedgen CRs to bypass the check altogether, for those steps:
>
>healthchecks.lca.openshift.io/subscriptions: Disabled
>
>
Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot]
donpenney
jc-rh
pixelsoccupied
Missxiaoguo
romfreiman
openshift-merge-robot
Background / Context
LCA runs system health checks during SeedGen and IBU to ensure that the cluster is healthy and stable before proceeding.
Issue / Requirement / Reason for change
An unhealthy subscription means there may not be a corresponding CSV. The existing health checks validate the CSV status, but if the CSV doesn't exist, that health check passes. As a result, the user may generate a seed image, for example, without realizing that the desired operators have not actually been installed.
Solution / Feature Overview
Introducing a Subscription health check gives added protection by ensuring all subscriptions are in a healthy state.
Implementation Details
This update adds a Subscription check to the set of system health checks. The Subscription check ensures that each subscription CR has no Failed conditions set to true and CatalogSourcesUnhealthy is false, indicating the subscription is healthy.
This check is skipped in the postpivot Upgrade stage handler, as it is expected that the catalog sources will not have been updated at this point, and each subscription would therefore be reported as unhealthy.