openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade

Apache License 2.0

6 stars 26 forks source link

Update to golang 1.21 and k8s api 0.29.4 #522

Closed jc-rh closed 1 month ago

jc-rh commented 1 month ago

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

0.29.4 is the highest we can go with 1.21. The next one, 0.30.0, requires go 1.22

Other Information

leo8a commented 1 month ago

nice, wondering if this bump would fix https://github.com/openshift-kni/lifecycle-agent/issues/424

jc-rh commented 1 month ago

nice, wondering if this bump would fix #424

I am not sure. I use go 1.21 locally, never saw the issue.

Missxiaoguo commented 1 month ago

/lgtm

donpenney commented 1 month ago

/cc @rauhersu @fontivan

jc-rh commented 1 month ago

/retest

rauhersu commented 1 month ago

/hold

We will introduce the midstream changes prior to this MR

Cc: @fontivan

donpenney commented 1 month ago

/unhold

donpenney commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment