OCPBUGS-32553: Adding ChronyConfig param to seed reconfiguration

[tsorya]

This param will allow to provide data to /etc/chrony.conf that will be used in order to oeverride seed data in the same file in order to allow setup of user ntp servers.

Currently i added it as full configuration taken from IBU cluster that will be written after upgrade, though maybe better to split configuration and provide it as additional ntp server as assisted installer uses it? In assisted we have default chrony.conf and allow to provide additional ntp servers

Default : pool 0.rhel.pool.ntp.org iburst driftfile /var/lib/chrony/drift makestep 1.0 3 rtcsync logdir /var/log/chrony

Adding default ntp servers like : server <provided ntp server> iburst

Adding logic to provide chrony.conf to recert Restarting chronyd in post-pivot phase after running recert in order to apply new chrony.conf

depends on https://github.com/rh-ecosystem-edge/recert/pull/145

[openshift-ci-robot]

@tsorya: This pull request references Jira Issue OCPBUGS-32553, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/524): >This param will allow to provide data to /etc/chrony.conf that will be used in order to oeverride seed data in the same file in order to allow setup of user ntp servers. > >Currently i added it as full configuration taken from IBU cluster that will be written after upgrade, though maybe better to split configuration and provide it as additional ntp server as assisted installer uses it? >In assisted we have default chrony.conf and allow to provide additional ntp servers > >Default : >`pool 0.rhel.pool.ntp.org iburst >driftfile /var/lib/chrony/drift >makestep 1.0 3 >rtcsync >logdir /var/log/chrony` > >Adding default ntp servers like : >`server iburst` > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[openshift-ci-robot]

@tsorya: An error was encountered searching for bug OCPBUGS-32553 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 401:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/524): >This param will allow to provide data to /etc/chrony.conf that will be used in order to oeverride seed data in the same file in order to allow setup of user ntp servers. > >Currently i added it as full configuration taken from IBU cluster that will be written after upgrade, though maybe better to split configuration and provide it as additional ntp server as assisted installer uses it? >In assisted we have default chrony.conf and allow to provide additional ntp servers > >Default : >`pool 0.rhel.pool.ntp.org iburst >driftfile /var/lib/chrony/drift >makestep 1.0 3 >rtcsync >logdir /var/log/chrony` > >Adding default ntp servers like : >`server iburst` > >depends on https://github.com/rh-ecosystem-edge/recert/pull/145 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

@tsorya: This pull request references Jira Issue OCPBUGS-32553, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/524): >This param will allow to provide data to /etc/chrony.conf that will be used in order to oeverride seed data in the same file in order to allow setup of user ntp servers. > >Currently i added it as full configuration taken from IBU cluster that will be written after upgrade, though maybe better to split configuration and provide it as additional ntp server as assisted installer uses it? >In assisted we have default chrony.conf and allow to provide additional ntp servers > >Default : >`pool 0.rhel.pool.ntp.org iburst >driftfile /var/lib/chrony/drift >makestep 1.0 3 >rtcsync >logdir /var/log/chrony` > >Adding default ntp servers like : >`server iburst` > >Adding logic to provide chrony.conf to recert >Restarting chronyd in post-pivot phase after running recert in order to >apply new chrony.conf > >depends on https://github.com/rh-ecosystem-edge/recert/pull/145 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[donpenney]

/retest

[tsorya]

/test ibu-e2e-flow

[tsorya]

/hold for recert in v0

[jc-rh]

@tsorya @omertuc do guys have a plan on when to propagate the recert change to the release branches?

[tsorya]

/test ibu-e2e-flow

[tsorya]

@tsorya @omertuc do guys have a plan on when to propagate the recert change to the release branches?

@jc-rh was pushed to v0 lets push this one, test and then push to 4.15 i think

[donpenney]

@tsorya @omertuc do guys have a plan on when to propagate the recert change to the release branches?

@jc-rh was pushed to v0 lets push this one, test and then push to 4.15 i think

If there's a dependent recert change, we'll need it in the 4.14, 4.15, and 4.16 release branches before we can resync the LCA release branches to pick up this PR

[tsorya]

@tsorya @omertuc do guys have a plan on when to propagate the recert change to the release branches?

@jc-rh was pushed to v0 lets push this one, test and then push to 4.15 i think

If there's a dependent recert change, we'll need it in the 4.14, 4.15, and 4.16 release branches before we can resync the LCA release branches to pick up this PR

Sounds like, though i would like to test it before backporting everything. I tested it manually but i would like to have QE verify too. So we need to push to master, test it, get qe verified and than backport it in recert and lca

[donpenney]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[tsorya]

/unhold

[tsorya]

/remove-label cluster-config-api-changed

[openshift-ci[bot]]

@tsorya: Those labels are not set on the issue: cluster-config-api-changed

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/524#issuecomment-2137959078): >/remove-label cluster-config-api-changed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-ci-robot]

@tsorya: Jira Issue OCPBUGS-32553: All pull requests linked via external trackers have merged:

• openshift-kni/lifecycle-agent#524
• rh-ecosystem-edge/recert#145

Jira Issue OCPBUGS-32553 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/524): >This param will allow to provide data to /etc/chrony.conf that will be used in order to oeverride seed data in the same file in order to allow setup of user ntp servers. > >Currently i added it as full configuration taken from IBU cluster that will be written after upgrade, though maybe better to split configuration and provide it as additional ntp server as assisted installer uses it? >In assisted we have default chrony.conf and allow to provide additional ntp servers > >Default : >`pool 0.rhel.pool.ntp.org iburst >driftfile /var/lib/chrony/drift >makestep 1.0 3 >rtcsync >logdir /var/log/chrony` > >Adding default ntp servers like : >`server iburst` > >Adding logic to provide chrony.conf to recert >Restarting chronyd in post-pivot phase after running recert in order to >apply new chrony.conf > >depends on https://github.com/rh-ecosystem-edge/recert/pull/145 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.