search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

MGMT-16515: in order to set machine network in node ip hint file in post pivot we should take it from target #525

Closed tsorya closed 1 month ago

tsorya commented 1 month ago

MGMT-16515: in order to set machine network in node ip hint file in post pivot we should take it from target

Background / Context

MGMT-16515: in order to set machine network in node ip hint file in post pivot we should take it from target

Issue / Requirement / Reason for change

Solution / Feature Overview

This pr adds logic to take machine network from install-config of upgraded sno and set it in seed reconfiguration api. Post pivot will use this field and set it in nodeip hint file in order require from node-configuration service to set kubelet ip from the machine network we provided

Implementation Details

Other Information

openshift-ci-robot commented 1 month ago

@tsorya: This pull request references MGMT-16515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/525): >[MGMT-16515](https://issues.redhat.com//browse/MGMT-16515): in order to set machine network in node ip hint file in post pivot we should take it from target > > ># Background / Context >[MGMT-16515](https://issues.redhat.com//browse/MGMT-16515): in order to set machine network in node ip hint file in post pivot we should take it from target > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview >This pr adds logic to take machine network from install-config of upgraded sno and set it in seed reconfiguration api. >Post pivot will use this field and set it in nodeip hint file in order require from node-configuration service to set kubelet ip from the machine network we provided > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@tsorya: This pull request references MGMT-16515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/525): >[MGMT-16515](https://issues.redhat.com//browse/MGMT-16515): in order to set machine network in node ip hint file in post pivot we should take it from target > > ># Background / Context >[MGMT-16515](https://issues.redhat.com//browse/MGMT-16515): in order to set machine network in node ip hint file in post pivot we should take it from target > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview >This pr adds logic to take machine network from install-config of upgraded sno and set it in seed reconfiguration api. >Post pivot will use this field and set it in nodeip hint file in order require from node-configuration service to set kubelet ip from the machine network we provided > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tsorya commented 1 month ago

Will this play nice with #422?

this is exactly the idea

donpenney commented 1 month ago

/retest

eranco74 commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment