search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

OCPBUGS-34010: In case proxy status was set there is no reason to update proxy in post pivot phase (IBU flow) #526

Closed tsorya closed 1 month ago

tsorya commented 1 month ago

OCPBUGS-34010: In case proxy status was set there is no reason to update proxy in post pivot phase (IBU flow)

Background / Context

In IBU flow we take proxy and proxy status from upgraded cluster and there is no need to update those values in post-pivot

Issue / Requirement / Reason for change

failure in proxy installation

openshift-ci-robot commented 1 month ago

@tsorya: This pull request references Jira Issue OCPBUGS-34010, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/526): >OCPBUGS-34010: In case proxy status was set there is no reason to update proxy in post pivot phase (IBU flow) > > ># Background / Context >In IBU flow we take proxy and proxy status from upgraded cluster and there is no need to update those values in post-pivot > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@tsorya: This pull request references Jira Issue OCPBUGS-34010, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/526): >OCPBUGS-34010: In case proxy status was set there is no reason to update proxy in post pivot phase (IBU flow) > > ># Background / Context >In IBU flow we take proxy and proxy status from upgraded cluster and there is no need to update those values in post-pivot > > ># Issue / Requirement / Reason for change >failure in proxy installation > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tsorya commented 1 month ago

/test integration

tsorya commented 1 month ago

tested by @mcornea

tsorya commented 1 month ago

/test ibu-e2e-flow

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@tsorya: Jira Issue OCPBUGS-34010: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34010 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/526): >OCPBUGS-34010: In case proxy status was set there is no reason to update proxy in post pivot phase (IBU flow) > > ># Background / Context >In IBU flow we take proxy and proxy status from upgraded cluster and there is no need to update those values in post-pivot > > ># Issue / Requirement / Reason for change >failure in proxy installation > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.