openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade

Apache License 2.0

6 stars 28 forks source link

docs: Update seedgen prereqs section #527

Closed donpenney closed 2 months ago

donpenney commented 4 months ago

Background / Context

Seed generation doc has been updated to expand the pre-requisites section with additional information about seed SNO criteria and alignment with target SNOs.

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

leo8a commented 4 months ago

maybe this PR can also drop a note on the dnsmaq configuration section like below... or remove it since the minimum supported version of ACM should be +4.10

> [!NOTE]
> The dnsmasq configuration section is only relevant when the version of ACM used is below v2.9.2.

donpenney commented 2 months ago

maybe this PR can also drop a note on the dnsmaq configuration section like below... or remove it since the minimum supported version of ACM should be +4.10
> [!NOTE]
> The dnsmasq configuration section is only relevant when the version of ACM used is below v2.9.2.

Thanks @leo8a . I added a note to the line that the required config is automatically included if deployed via ACM >= 2.9.2. We could consider removing the check from seedgen completely, but would likely need to include some analogous check of the dnsmasq config for the case where the node has not been deployed via ACM at all.

donpenney commented 2 months ago

/cc @browsell @jc-rh

donpenney commented 2 months ago

/cc @leo8a

leo8a commented 2 months ago

/lgtm

browsell commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [browsell] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

donpenney commented 2 months ago

/cherrypick release-4.16 release-4.15 release-4.14

openshift-cherrypick-robot commented 2 months ago

@donpenney: new pull request created: #606

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/527#issuecomment-2217524858): >/cherrypick release-4.16 release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.