search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

OCPBUGS-34520: add additional checks to validate if oadp is installed #542

Closed pixelsoccupied closed 1 month ago

pixelsoccupied commented 1 month ago

Background / Context

LCA may incorrectly try to delete OADP resources if configured with proxy even though no OADP is not present/installed

e.g error

2024-05-23T21:04:01Z    ERROR   controllers.ImageBasedUpgrade.Idle  failed to cleanup backups   {"error": "failed to list Backup: failed to get API group resources: unable to retrieve the complete list of server APIs: velero.io/v1: the server could not find the requested resource"}

Solution / Feature Overview

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 1 month ago

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-34520, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/542): >https://issues.redhat.com/browse/OCPBUGS-34520 > > ># Background / Context > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-34520, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yliu127

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/542): ># Background / Context > >Target cluster's LCA may incorrectly try to delete OADP resources if configured with proxy even though no OADP was installed > >``` >2024-05-23T21:04:01Z ERROR controllers.ImageBasedUpgrade.Idle failed to cleanup backups {"error": "failed to list Backup: failed to get API group resources: unable to retrieve the complete list of server APIs: velero.io/v1: the server could not find the requested resource"} >``` > ># Solution / Feature Overview > >- before a cleanup LCA makes sure OADP installed by checking with OADP's CRDs >- Increased checks > ># Implementation Details > > > ># Other Information > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-34520, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yliu127

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/542): ># Background / Context > >Target cluster's LCA may incorrectly try to delete OADP resources if configured with proxy even though no OADP is not present/installed > >e.g error >``` >2024-05-23T21:04:01Z ERROR controllers.ImageBasedUpgrade.Idle failed to cleanup backups {"error": "failed to list Backup: failed to get API group resources: unable to retrieve the complete list of server APIs: velero.io/v1: the server could not find the requested resource"} >``` > ># Solution / Feature Overview > >- before a cleanup LCA makes sure OADP is installed by checking for presence of OADP's CRDs >- improved checks when listing OADP resources > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pixelsoccupied commented 1 month ago

/uncc @omertuc /cc @Missxiaoguo

openshift-ci-robot commented 1 month ago

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-34520, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yliu127

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/542): ># Background / Context > >LCA may incorrectly try to delete OADP resources if configured with proxy even though no OADP is not present/installed > >e.g error >``` >2024-05-23T21:04:01Z ERROR controllers.ImageBasedUpgrade.Idle failed to cleanup backups {"error": "failed to list Backup: failed to get API group resources: unable to retrieve the complete list of server APIs: velero.io/v1: the server could not find the requested resource"} >``` > ># Solution / Feature Overview > >- before a cleanup LCA makes sure OADP is installed by checking for presence of OADP's CRDs >- improved checks when listing OADP resources > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jc-rh commented 1 month ago

/lgtm

tsorya commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [tsorya] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@pixelsoccupied: Jira Issue OCPBUGS-34520: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34520 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/542): ># Background / Context > >LCA may incorrectly try to delete OADP resources if configured with proxy even though no OADP is not present/installed > >e.g error >``` >2024-05-23T21:04:01Z ERROR controllers.ImageBasedUpgrade.Idle failed to cleanup backups {"error": "failed to list Backup: failed to get API group resources: unable to retrieve the complete list of server APIs: velero.io/v1: the server could not find the requested resource"} >``` > ># Solution / Feature Overview > >- before a cleanup LCA makes sure OADP is installed by checking for presence of OADP's CRDs >- improved checks when listing OADP resources > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.