openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade

Apache License 2.0

6 stars 26 forks source link

NO-ISSUE: in case there is no oadp content we should not try to bring it #545

Closed tsorya closed 1 month ago

tsorya commented 1 month ago

NO-ISSUE: in case there is no oadp content we should not try to bring it.

Background / Context

If user didn't propvide oadp content in upgrade cr we should not try to bring

Issue / Requirement / Reason for change

Solution / Feature Overview

Skip oadp content gathering in case it was not asked

Implementation Details

Other Information

openshift-ci-robot commented 1 month ago

@tsorya: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/545): >NO-ISSUE: in case there is no oadp content we should not try to bring it. > > > ># Background / Context >If user didn't propvide oadp content in upgrade cr we should not try to bring > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 1 month ago

@tsorya: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/545): >NO-ISSUE: in case there is no oadp content we should not try to bring it. > > > ># Background / Context >If user didn't propvide oadp content in upgrade cr we should not try to bring > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview >Skip oadp content gathering in case it was not asked > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

pixelsoccupied commented 1 month ago

/lgtm

tsorya commented 1 month ago

/retest

tsorya commented 1 month ago

/test ci-index

pixelsoccupied commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment