search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

MGMT-16859: Provide an option to configure mirror registry in installation iso #546

Closed tsorya closed 1 month ago

tsorya commented 1 month ago

MGMT-16859: Provide an option to configure mirror registry in installation iso

Background / Context

We need to be able to pull images in installation iso, in case of mirror registry we must configure registry.conf file in order to be able to pull those images

Issue / Requirement / Reason for change

Solution / Feature Overview

Add mirror-registry cli param for ib-cli in order to get path to mirror registry config file

Implementation Details

Other Information

openshift-ci-robot commented 1 month ago

@tsorya: This pull request references MGMT-16859 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/546): >[MGMT-16859](https://issues.redhat.com//browse/MGMT-16859): Provide an option to configure mirror registry in installation iso > > ># Background / Context >We need to be able to pull images in installation iso, in case of mirror registry we must configure registry.conf file in order to be able to pull those images > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview >Add mirror-registry cli param for ib-cli in order to get path to mirror registry config file > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@tsorya: This pull request references MGMT-16859 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/546): >[MGMT-16859](https://issues.redhat.com//browse/MGMT-16859): Provide an option to configure mirror registry in installation iso > > ># Background / Context >We need to be able to pull images in installation iso, in case of mirror registry we must configure registry.conf file in order to be able to pull those images > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview >Add mirror-registry cli param for ib-cli in order to get path to mirror registry config file > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tsorya commented 1 month ago

/test ibi-e2e-flow

eranco74 commented 1 month ago

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment