search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

MGMT-17989: Support static network configuration in installation iso #549

Closed tsorya closed 3 weeks ago

tsorya commented 1 month ago

MGMT-17989: Support static network configuration in installation iso This change allows to provide nmstate configuration that will be applied on installation iso. In case nmstate config was provided network configuration service will be added, this service run nmstatectl and applies provided config

openshift-ci-robot commented 1 month ago

@tsorya: This pull request references MGMT-17989 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/549): >[MGMT-17989](https://issues.redhat.com//browse/MGMT-17989): Support static network configuration in installation iso >This change allows to provide nmstate configuration that will be applied on installation iso. >In case nmstate config was provided network configuration service will be added, this service run nmstatectl and applies provided config > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@tsorya: This pull request references MGMT-17989 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/549): >[MGMT-17989](https://issues.redhat.com//browse/MGMT-17989): Support static network configuration in installation iso >This change allows to provide nmstate configuration that will be applied on installation iso. >In case nmstate config was provided network configuration service will be added, this service run nmstatectl and applies provided config > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from tsorya. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tsorya commented 4 weeks ago

/hold

tsorya commented 3 weeks ago

was pushed as part of https://github.com/openshift-kni/lifecycle-agent/pull/551