search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

MGMT-16402: Move to new api for ibi create installation iso #551

Closed tsorya closed 4 weeks ago

tsorya commented 1 month ago

Background / Context

MGMT-16402: Move to new api for ibi create installation iso

Issue / Requirement / Reason for change

As part of moving to openshift installer in 4.17 we want to have same api in 4.16 for ibi-cli

That's why we need to reformat current logic and to provide configuration file and not params.

Solution / Feature Overview

MGMT-16402: Move to new api for ibi create installation iso

  1. Adding new api struct ImageBasedInstallConfig
  2. Remove butane and start using ignition package
  3. Change mirror registry from string to ImageDigestSources

Implementation Details

Other Information

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 4 weeks ago

@tsorya: This pull request references MGMT-16402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/551): > > ># Background / Context > [MGMT-16402](https://issues.redhat.com//browse/MGMT-16402): Move to new api for ibi create installation iso > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview >[MGMT-16402](https://issues.redhat.com//browse/MGMT-16402): Move to new api for ibi create installation iso >1. Adding new api struct ImageBasedInstallConfig >2. Remove butane and start using ignition package >3. Change mirror registry from string to ImageDigestSources > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 weeks ago

@tsorya: This pull request references MGMT-16402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/551): > > ># Background / Context > [MGMT-16402](https://issues.redhat.com//browse/MGMT-16402): Move to new api for ibi create installation iso > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview >[MGMT-16402](https://issues.redhat.com//browse/MGMT-16402): Move to new api for ibi create installation iso >1. Adding new api struct ImageBasedInstallConfig >2. Remove butane and start using ignition package >3. Change mirror registry from string to ImageDigestSources > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 weeks ago

@tsorya: This pull request references MGMT-16402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/551): > > ># Background / Context > [MGMT-16402](https://issues.redhat.com//browse/MGMT-16402): Move to new api for ibi create installation iso > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview >[MGMT-16402](https://issues.redhat.com//browse/MGMT-16402): Move to new api for ibi create installation iso >1. Adding new api struct ImageBasedInstallConfig >2. Remove butane and start using ignition package >3. Change mirror registry from string to ImageDigestSources > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 weeks ago

@tsorya: This pull request references MGMT-16402 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/551): > > ># Background / Context > [MGMT-16402](https://issues.redhat.com//browse/MGMT-16402): Move to new api for ibi create installation iso > > ># Issue / Requirement / Reason for change >As part of moving to openshift installer in 4.17 we want to have same api in 4.16 for ibi-cli > >That's why we need to reformat current logic and to provide configuration file and not params. > > ># Solution / Feature Overview >[MGMT-16402](https://issues.redhat.com//browse/MGMT-16402): Move to new api for ibi create installation iso >1. Adding new api struct ImageBasedInstallConfig >2. Remove butane and start using ignition package >3. Change mirror registry from string to ImageDigestSources > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tsorya commented 4 weeks ago

/test ibu-e2e-flow

openshift-ci[bot] commented 4 weeks ago

@tsorya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibi-e2e-flow c1345efbe72fe222348ff3af6d12e3a8cd8d30a5 link false /test ibi-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
eranco74 commented 4 weeks ago

The job is failing because the API changes require these changes. /lgtm /approve

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment