search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

MGMT-18049: Refactor ibi code to use assisted-image-service in order to embed ignition into iso #553

Closed tsorya closed 3 weeks ago

tsorya commented 3 weeks ago

MGMT-18049: Refactor ibi code to use assisted-image-service in order to embed ignition into iso

Background / Context

Currently we embed ignition into iso by using coreos-install container. We want to remove usage of required containers in order to minimize requirements for mirroring

We should move to assisted-image-service library that allows to do the same

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

openshift-ci-robot commented 3 weeks ago

@tsorya: This pull request references MGMT-18049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/553): >[MGMT-18049](https://issues.redhat.com//browse/MGMT-18049): Refactor ibi code to use assisted-image-service in order to embed ignition into iso > > ># Background / Context >Currently we embed ignition into iso by using coreos-install container. We want to remove usage of required containers in order to minimize requirements for mirroring > >We should move to assisted-image-service library that allows to do the same > > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@tsorya: This pull request references MGMT-18049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/553): >[MGMT-18049](https://issues.redhat.com//browse/MGMT-18049): Refactor ibi code to use assisted-image-service in order to embed ignition into iso > > ># Background / Context >Currently we embed ignition into iso by using coreos-install container. We want to remove usage of required containers in order to minimize requirements for mirroring > >We should move to assisted-image-service library that allows to do the same > > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tsorya commented 3 weeks ago

/test ibi-e2e-flow

tsorya commented 3 weeks ago

/test ibi-e2e-flow

leo8a commented 3 weeks ago

/test ibi-e2e-flow

donpenney commented 3 weeks ago

/retest

donpenney commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 weeks ago

@tsorya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibi-e2e-flow 0e569bbb92efd259c24e13e233ebce885168194a link false /test ibi-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).