search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

NO-ISSUE: handle case for static ip configuration without provide node ip (IBI) #554

Closed tsorya closed 3 weeks ago

tsorya commented 3 weeks ago

NO-ISSUE: In order to handle case for static ip configuration and without provided nodeip (IBI flow) we need to restart newtork manager before running nodeip configuration service.

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

openshift-ci-robot commented 3 weeks ago

@tsorya: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/554): >NO-ISSUE: In order to handle case for static ip configuration and without provided nodeip (IBI flow) we need to restart newtork manager before running nodeip configuration service. > > > ># Background / Context > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
leo8a commented 3 weeks ago

/lgtm

leo8a commented 3 weeks ago 
error: failed to get network 'ib-orchestrate-1'
error: Network not found: no network with matching name 'ib-orchestrate-1'

/test ibi-e2e-flow

openshift-ci-robot commented 3 weeks ago

@tsorya: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/554): >NO-ISSUE: In order to handle case for static ip configuration and without provided nodeip (IBI flow) we need to restart newtork manager before running nodeip configuration service. > > > ># Background / Context > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
eranco74 commented 3 weeks ago

/approve

leo8a commented 3 weeks ago

/lgtm

javipolo commented 3 weeks ago

/approve /lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, javipolo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tsorya commented 3 weeks ago

/test images

tsorya commented 3 weeks ago

/test integration

openshift-ci[bot] commented 3 weeks ago

@tsorya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibi-e2e-flow b646578941e4f5b2e0208e7fdc39dd9851a858eb link false /test ibi-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tsorya commented 3 weeks ago

/retest-required