search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

OCPBUGS-32493: remove redundant retry wrappers #555

Closed pixelsoccupied closed 3 weeks ago

pixelsoccupied commented 3 weeks ago

Background / Context

This builds on https://github.com/openshift-kni/lifecycle-agent/pull/548 to clean up the existing explicitly wrapped client calls since they are redundant

/cc @jc-rh @Missxiaoguo

openshift-ci-robot commented 3 weeks ago

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32493, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/555): ># Background / Context > >This builds on https://github.com/openshift-kni/lifecycle-agent/pull/548 to clean up the existing explicitly wrapped client calls since they are redundant > >Only RetryOnConflict is explicitly called when status update is needed > >/cc @jc-rh @Missxiaoguo Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pixelsoccupied commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32493, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yliu127

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/555#issuecomment-2150534464): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pixelsoccupied commented 3 weeks ago

/hold

we tested and found that the way .Update was wrapped to retry was basically unused since we must retrieve the latest CR first before retrying in case of conflicts e.g see here

I'm removing them as currently having them is really just delaying the error. Let's open up another PR if conflict truly needs to be retriable as this is beyond the scope of this cleanup

openshift-ci-robot commented 3 weeks ago

@pixelsoccupied: This pull request references Jira Issue OCPBUGS-32493, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/555): ># Background / Context > >This builds on https://github.com/openshift-kni/lifecycle-agent/pull/548 to clean up the existing explicitly wrapped client calls since they are redundant > >/cc @jc-rh @Missxiaoguo Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pixelsoccupied commented 3 weeks ago

/unhold

jc-rh commented 3 weeks ago

/lgtm

Missxiaoguo commented 3 weeks ago

/lgtm

pixelsoccupied commented 3 weeks ago

/retest

openshift-ci[bot] commented 3 weeks ago

@pixelsoccupied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibu-e2e-flow a12c2ea3b4e98504a6c8105a0aea0dca316f4256 link false /test ibu-e2e-flow
ci/prow/ibi-e2e-flow a12c2ea3b4e98504a6c8105a0aea0dca316f4256 link false /test ibi-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jc-rh commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [jc-rh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

@pixelsoccupied: Jira Issue OCPBUGS-32493: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32493 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/555): ># Background / Context > >This builds on https://github.com/openshift-kni/lifecycle-agent/pull/548 to clean up the existing explicitly wrapped client calls since they are redundant > >/cc @jc-rh @Missxiaoguo Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.