openshift-ci-robot
commented
3 weeks ago @donpenney: This pull request references Jira Issue OCPBUGS-34089, which is invalid:
- expected the bug to target the "4.17.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/561):
>This update adds checks to IBU and seedgen to ensure:
>- container storage is setup shared, ie. is a mountpoint
>- the mountpoint target for the seed image is the same as the mountpoint target on the running cluster
>
># Background / Context
>
>IBU requires container storage setup such that it is shared between stateroots. The configuration of the shared storage is up to the user, but the mountpoint target (eg. `/dev/disk/by-partlabel/varlibcontainers`) must be the same on both seed and target SNO.
>
># Issue / Requirement / Reason for change
>
>If the seed image is generated on an SNO with a different container storage mountpoint target, the upgraded SNO may fail to boot, as the mountpoint target would not exist.
>
># Solution / Feature Overview
>
>In order to prevent such a configuration mismatch, LCA has been updated to include checks for the container storage setup.
>- If container storage is not setup shared, ie. a mountpoint:
> - A seedgen request will be rejected
> - IBU Prep stage will fail
>- If the container storage config in the seed image does not align with the running cluster, the IBU Prep stage will fail
>
># Implementation Details
>
>LCA parses the var-lib-containers.mount service unit to determine the mountpoint target, as defined by the `What` config variable. This path is added to the seed config information, which is included in the seed image label. This label is checked during IBU Prep to ensure that it matches the configuration on the running cluster.
Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
donpenney
browsell
openshift-ci[bot]
This update adds checks to IBU and seedgen to ensure:
Background / Context
IBU requires container storage setup such that it is shared between stateroots. The configuration of the shared storage is up to the user, but the mountpoint target (eg.
/dev/disk/by-partlabel/varlibcontainers) must be the same on both seed and target SNO.Issue / Requirement / Reason for change
If the seed image is generated on an SNO with a different container storage mountpoint target, the upgraded SNO may fail to boot, as the mountpoint target would not exist.
Solution / Feature Overview
In order to prevent such a configuration mismatch, LCA has been updated to include checks for the container storage setup.
Implementation Details
LCA parses the var-lib-containers.mount service unit to determine the mountpoint target, as defined by the
Whatconfig variable. This path is added to the seed config information, which is included in the seed image label. This label is checked during IBU Prep to ensure that it matches the configuration on the running cluster.