search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

OCPBUGS-35078: Add CSV relatedImages to seed containers.list #563

Closed donpenney closed 3 weeks ago

donpenney commented 3 weeks ago

Background / Context

During seed generation, a list of all images on the seed SNO is collected, for use in precaching. For some operators, however, this may not be a complete list of required images, as images may be pulled at runtime based on configuration that may not be present on the seed SNO. This will result on such images being pulled post-pivot.

Solution / Feature Overview

In addition to the images present on the seed SNO, this update extends seedgen to also scan the installed CSVs to include relatedImages from the CSV specs in the image list. This ensures that those missing images are included during precaching.

openshift-ci-robot commented 3 weeks ago

@donpenney: This pull request references Jira Issue OCPBUGS-35078, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @yliu127

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/563): ># Background / Context > >During seed generation, a list of all images on the seed SNO is collected, for use in precaching. For some operators, however, this may not be a complete list of required images, as images may be pulled at runtime based on configuration that may not be present on the seed SNO. This will result on such images being pulled post-pivot. > ># Solution / Feature Overview > >In addition to the images present on the seed SNO, this update extends seedgen to also scan the installed CSVs to include relatedImages from the CSV specs in the image list. This ensures that those missing images are included during precaching. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
donpenney commented 3 weeks ago

/cc @browsell

browsell commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

@donpenney: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibu-e2e-flow 209d236be3198f10c8714bfb90370de5890499fc link false /test ibu-e2e-flow
ci/prow/ibi-e2e-flow 209d236be3198f10c8714bfb90370de5890499fc link false /test ibi-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
browsell commented 3 weeks ago

/test ibu-e2e-flow

browsell commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [browsell] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

@donpenney: Jira Issue OCPBUGS-35078: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35078 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/563): ># Background / Context > >During seed generation, a list of all images on the seed SNO is collected, for use in precaching. For some operators, however, this may not be a complete list of required images, as images may be pulled at runtime based on configuration that may not be present on the seed SNO. This will result on such images being pulled post-pivot. > ># Solution / Feature Overview > >In addition to the images present on the seed SNO, this update extends seedgen to also scan the installed CSVs to include relatedImages from the CSV specs in the image list. This ensures that those missing images are included during precaching. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.