search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

NO-ISSUE: in case node ip was not provided, dnsmasq condifuration should run after setting node ip #564

Closed tsorya closed 3 weeks ago

tsorya commented 3 weeks ago

NO-ISSUE: in case node ip was not provided, dnsmasq condifuration should run after setting node ip

Background / Context

If node ip was not provided as part of IBI flow we run node-ip configuration service that should set node ip and only after that we should run dnsmasq configuration

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

openshift-ci-robot commented 3 weeks ago

@tsorya: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/564): >NO-ISSUE: in case node ip was not provided, dnsmasq condifuration should run after setting node ip > > ># Background / Context >If node ip was not provided as part of IBI flow we run node-ip configuration service that should set node ip and only after that we should run dnsmasq configuration > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment