openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

MGMT-16608: Support post deployment tasks #577

Closed tsorya closed 2 weeks ago

tsorya commented 2 weeks ago

MGMT-16608: Support post deployment tasks As part of ibi installation we want to support post deployment script option. Adding logic were user drops post.sh file with bash code in working folder, we will add it to installation ignition and run.

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

openshift-ci-robot commented 2 weeks ago

@tsorya: This pull request references MGMT-16608 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/577): >[MGMT-16608](https://issues.redhat.com//browse/MGMT-16608): Support post deployment tasks >As part of ibi installation we want to support post deployment script option. >Adding logic were user drops post.sh file with bash code in working folder, we will add it to installation ignition and run. > > > ># Background / Context > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@tsorya: This pull request references MGMT-16608 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/577): >[MGMT-16608](https://issues.redhat.com//browse/MGMT-16608): Support post deployment tasks >As part of ibi installation we want to support post deployment script option. >Adding logic were user drops post.sh file with bash code in working folder, we will add it to installation ignition and run. > > > ># Background / Context > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
eranco74 commented 2 weeks ago

/approve /lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment