openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 26 forks source link

NO-ISSUE: remove sed in post pivot flow as logic was moved to recert #580

Open tsorya opened 1 week ago

tsorya commented 1 week ago

Background / Context

This logic was moved to recert so there is no need to run sed anymore.

Related recert PR: https://github.com/rh-ecosystem-edge/recert/pull/147

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

openshift-ci-robot commented 1 week ago

@tsorya: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/580): > > ># Background / Context >This logic was moved to recert so there is no need to run sed anymore > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from tsorya. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 days ago

@tsorya: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/580): > > ># Background / Context >This logic was moved to recert so there is no need to run sed anymore. > >Related recert PR: https://github.com/rh-ecosystem-edge/recert/pull/147 > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.