openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade

Apache License 2.0

6 stars 26 forks source link

CNF-12206: introduce new .status.history field to understand timing of each stage and their phases #585

Open pixelsoccupied opened 6 days ago

pixelsoccupied commented 6 days ago

Background / Context

A new status history field is added to understand when and for how long each stage may run successfully.

Solution / Feature Overview

History is reset when Idle.
Each history entry on the list will appear chronologically and will have startTime to indicated when a stage was called for the first time. Optionally completionTime will appear when the stage is successful.
A stage may have a one or more Phase to help understand important tasks that were performed. Similar to history entries, each Phase will have a startTime and optionally a completionTime.
- 'Prep' stage entry will have the follow:
  - Stateroot: Time taken to create the new stateroot.
  - Precache: Time taken to pull all images specified by the image list built into the seed image.
- 'Upgrade' stage entry will have the follow:
  - PrePivot: Time taken complete all the steps before reboot is called
  - PostPivot: Time taken complete all the steps after a reboot to a new stateroot
  - Reboot time can be calculated with PrePivot completionTime and PostPivot startTime.

Other Information

/cc @Missxiaoguo @jc-rh @donpenney

openshift-ci-robot commented 6 days ago

@pixelsoccupied: This pull request references CNF-12206 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/585): >TODO description > > ># Background / Context > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > >/cc @Missxiaoguo @jc-rh @donpenney Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci-robot commented 6 days ago

@pixelsoccupied: This pull request references CNF-12206 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/585): ># Background / Context > >A new status `history` field is added to understand when and for how long each stage may run successfully. > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > >- History is reset when `Idle`. >- Each history entry on the list will appear chronologically and will have `startTime` to indicated when a stage was called for the first time. Optionally `completionTime` will appear when the stage is successful. >- A stage may have a one or more `Phase` to help understand important tasks that were performed. Similar to history entries, each `Phase` will have a `startTime` and optionally a `completionTime`. > - 'Prep' stage entry will have the follow: > - `Stateroot`: Time taken to create the new stateroot. > - `Precache`: Time taken to pull all images specified by the image list built into the seed image. > - 'Upgrade' stage entry will have the follow: > - `PrePivot`: Time taken complete all the steps before reboot is called > - `PostPivot`: Time taken complete all the steps after a reboot to a new stateroot > - Reboot time can be calculated with PrePivot completionTime and PostPivot startTime. > ># Other Information > > > > > >/cc @Missxiaoguo @jc-rh @donpenney Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 6 days ago

@pixelsoccupied: This pull request references CNF-12206 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/585): ># Background / Context > >A new status `history` field is added to understand when and for how long each stage may run successfully. > > ># Solution / Feature Overview > >- History is reset when `Idle`. >- Each history entry on the list will appear chronologically and will have `startTime` to indicated when a stage was called for the first time. Optionally `completionTime` will appear when the stage is successful. >- A stage may have a one or more `Phase` to help understand important tasks that were performed. Similar to history entries, each `Phase` will have a `startTime` and optionally a `completionTime`. > - 'Prep' stage entry will have the follow: > - `Stateroot`: Time taken to create the new stateroot. > - `Precache`: Time taken to pull all images specified by the image list built into the seed image. > - 'Upgrade' stage entry will have the follow: > - `PrePivot`: Time taken complete all the steps before reboot is called > - `PostPivot`: Time taken complete all the steps after a reboot to a new stateroot > - Reboot time can be calculated with PrePivot completionTime and PostPivot startTime. > ># Other Information > > > > > >/cc @Missxiaoguo @jc-rh @donpenney Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

pixelsoccupied commented 6 days ago

/test integration