openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 28 forks source link

NO-ISSUE: Fix unittest for CleanupBackups #638

Closed Missxiaoguo closed 1 month ago

Missxiaoguo commented 1 month ago

Background / Context

Fix the race condition in the testcase for CleanupBackups. To mock the deletion of a backup, backup CR should be deleted first, followed by the backupDeleteRequest CR.

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Missxiaoguo commented 1 month ago

/cc @donpenney @leo8a

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [donpenney] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@Missxiaoguo: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/638): > > ># Background / Context >Fix the race condition in the testcase for CleanupBackups. To mock the deletion of a backup, backup CR should be deleted first, followed by the backupDeleteRequest CR. > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@Missxiaoguo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibu-e2e-flow 5a63166733e9e6bd2af71908572fa0da1ecc54c0 link false /test ibu-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
donpenney commented 1 month ago

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14

openshift-cherrypick-robot commented 1 month ago

@donpenney: new pull request created: #645

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/638#issuecomment-2321887720): >/cherrypick release-4.17 release-4.16 release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.