search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 28 forks source link

MGMT-18928: take first image from .repoDigests #657

Closed tsorya closed 2 weeks ago

tsorya commented 2 weeks ago

Background / Context

MGMT-18928: take first image from .repoDigests While precaching images we pull all the images in parallel, some of them are pulled twice cause they have more than one repoDigest, though it is totally same image. Pulling them in parallel can cause podman to corrupt it though it finish ok

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

openshift-ci-robot commented 2 weeks ago

@tsorya: This pull request references MGMT-18928 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/657): > > ># Background / Context > > [MGMT-18928](https://issues.redhat.com//browse/MGMT-18928): take first image from .repoDigests > While precaching images we pull all the images in parallel, > some of them are pulled twice cause they have more than one repoDigest, though it is totally same image. > Pulling them in parallel can cause podman to corrupt it though it finish ok > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@tsorya: This pull request references MGMT-18928 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/657): > > ># Background / Context > > [MGMT-18928](https://issues.redhat.com//browse/MGMT-18928): take first image from .repoDigests > While precaching images we pull all the images in parallel, > some of them are pulled twice cause they have more than one repoDigest, though it is totally same image. > Pulling them in parallel can cause podman to corrupt it though it finish ok > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
omertuc commented 2 weeks ago

/approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [omertuc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tsorya commented 2 weeks ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 2 weeks ago

@tsorya: new pull request created: #658

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/657#issuecomment-2356338312): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.