search

openshift-kni / lifecycle-agent

Local agent for orchestration of SNO Image Based Upgrade
Apache License 2.0
6 stars 29 forks source link

Revert "MGMT-18928: take first image from .repoDigests" #659

Closed tsorya closed 2 months ago

tsorya commented 2 months ago

This reverts commit 279f0c6a5514a796bceb5d8a7b5565ca16764459. failed to reproduce issue locally, no need to change the logic if we can't reproduce it anymore

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

openshift-ci-robot commented 2 months ago

@tsorya: This pull request references MGMT-18928 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift-kni/lifecycle-agent/pull/659): >This reverts commit 279f0c6a5514a796bceb5d8a7b5565ca16764459. >failed to reproduce issue locally, no need to change the logic if we can't reproduce it anymore > > > ># Background / Context > > > ># Issue / Requirement / Reason for change > > > ># Solution / Feature Overview > > > ># Implementation Details > > > ># Other Information > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Flifecycle-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
eranco74 commented 2 months ago

/lgtm /approve

omertuc commented 2 months ago

It's still a good change IMO, why revert?

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/lifecycle-agent/blob/main/OWNERS)~~ [eranco74] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tsorya commented 2 months ago

/hold

tsorya commented 2 months ago

@omertuc to say the truth i don't think it will break something and is sort of good but till now it didn't bother and who knows what will be broken after all. Pretty difficult to validate it as we don't have CI for this specific case and QE runs it once in a version

tsorya commented 2 months ago

and it looks like podman is handling it well by pulling layer only once and skipping all other tries

omertuc commented 2 months ago

I don't have a strong opinion either way

tsorya commented 2 months ago

/retest

tsorya commented 2 months ago

/unhold