search

openshift-kni / node-label-operator

Operator for handling node labels based on their names
1 stars 1 forks source link

add support for taints #13

Open m-yosefpor opened 3 years ago

m-yosefpor commented 3 years ago

Being able to define taints on nodes which match a selector. for example:

apiVersion: node-labels.openshift.io/v1beta1
kind: Labels
metadata:
  name: taint-sample1
spec:
  nodeNamePatterns:
    - infra-.*
  labels:
    test.openshift.io/foo1: bar1
  taints:
    - effect: NoExecute
      key: node-role.kubernetes.io/infra

There is another node label operator (https://github.com/barpilot/node-labeler-operator) which seems to be deprecated (no activity since 2018), however it supports defining taints on nodes, based on a selector. Also that operator does not support regex name matching. I think it's really useful to have that feature in this operator as well.

slintes commented 3 years ago

Hi @m-yosefpor, I'm sorry, but we are not maintaining this operator. Our usecase changed before we actually started using it. I will add a note to the readme.

m-yosefpor commented 3 years ago

Thanks @slintes for informing.

m-yosefpor commented 3 years ago

I've written another operator with operator-sdk which supports labels, annotations, and taints, namepattern matching, and label matching, based on this operator and also https://github.com/barpilot/node-labeler-operator (the latter is also deprecated). We will open-source it soon, and share the link here if any one else is interested in such operator.

slintes commented 3 years ago

Sounds great 👍🏼